Make cursor to string migration reversible #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
reviewed
Aug 19, 2024
| @@ -12,7 +12,7 @@ def up | |||
|
|
|||
| def down | |||
| change_table(:maintenance_tasks_runs) do |t| | |||
| t.change(:cursor, :bigint) | |||
| t.change(:cursor, "bigint USING cursor::bigint") | |||
There was a problem hiding this comment.
This is postgresql specific, right? Which makes it broken for any other database. We should look for a solution that works for all adapters or branch in the worst case
There was a problem hiding this comment.
Ohhh, you're right, I forgot about that. I think the CAST function should be cross-platform.
I forgot that the double colons are a PostgreSQLism.
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #1065.