Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Proposal for porting @shopify/koa-shopify-auth to express #1502

Closed
hgezim opened this issue Jun 9, 2020 · 5 comments
Closed

Proposal for porting @shopify/koa-shopify-auth to express #1502

hgezim opened this issue Jun 9, 2020 · 5 comments

Comments

@hgezim
Copy link

hgezim commented Jun 9, 2020

Overview

I'm creating a port of @shopify/koa-shopify-auth for express.

Would you folks be interested in maintaining it?

@hgezim
Copy link
Author

hgezim commented Jun 12, 2020

@tbeseda
Copy link

tbeseda commented Jul 7, 2020

@hgezim Do you happen to know if this Koa middleware can be directly adapted to Express without modification to the package? Seems like it should be possible given how Koa and Express middleware share a lot of the same DNA.

@hgezim
Copy link
Author

hgezim commented Jul 8, 2020

@tbeseda 99% sure it can't be done without modifications. Koa uses context which has shorthands for request and response objects. The cookie library used by koa is different and has a different API. Koa and Express handle next() calls differently.

Did you try my package (https://github.com/hgezim/express-shopify-auth)?

@ismail-syed
Copy link
Contributor

Hey, thanks for the issue. We don't support express. Feel free to fork and create your own package that supports express.

@hgezim
Copy link
Author

hgezim commented Jul 22, 2020

@ismail-syed Feel free to read my messages. Already created my own package:

https://github.com/hgezim/express-shopify-auth

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants