Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Remove the async logic from the @shopify/react-graphql package #2693

Closed
wants to merge 2 commits into from

Conversation

egjiri
Copy link
Member

@egjiri egjiri commented Oct 18, 2023

Remove the async logic and the following package dependencies from the @shopify/react-graphql package

  • @shopify/async
  • @shopify/react-async
  • @shopify/react-hooks
  • @shopify/react-idle

This PR also does a major version bump of this package since it is a breaking change with functionality being removed.

@egjiri egjiri force-pushed the endri/react-graphql branch 3 times, most recently from dfe01b9 to 40be141 Compare October 18, 2023 14:41
@egjiri
Copy link
Member Author

egjiri commented Oct 18, 2023

/snapit

@znja znja closed this Oct 1, 2024
@shopify-shipitnext
Copy link

🔎 View this PR in Shipit Next.

ℹ️ Expand to learn how to deploy and handle emergencies using Shipit Next

Overview

Shipit Next will merge your code on your behalf because this repository uses Shipit Next and its merge queue.

To ship this PR, you can either:

Comment Commands

  • /shipit: Enqueue this PR into the merge queue where it will eventually be merged and deployed.
  • /cancel: Eject this PR from the merge queue and rebuild PRs that were enqueued after this PR.
  • /shipit --jump-queue: Enqueue this PR at the top of the merge queue where it will be included in the next deploy. Use this for non-emergency situations.
    - Emergency handling procedure for this command can be found here.
  • /shipit --emergency: Merge this PR directly into main and deploy to all environments once all require_for_emergency CI checks pass. Please be aware that changes deployed with this command will not be automatically rolled back.

Commands exclusive to Deploy Before Merge

  • /cancel --emergency: Eject this PR from the merge and rollback any deployments containing this PR.

Documentation

Questions or feedback?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants