This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
fixed app install #1022
Merged
fixed app install #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
katiedavis
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Tested in multiple cases! Looks good to me.
@pinpointcoder can you please sign the CLA and ping me when you've done so?
ragalie
approved these changes
Sep 23, 2019
Hi @katiedavis, I have signed the CLA. Thanks for the approval, glad I could help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify koa auth install fails when the user is trying to install the app
Fixes (issue #)
During the shopify app install, shopify-koa-auth tries to redirect user to a page that does not exist (until the application is installed) yet. This causes the installation to fail. However when the user tries it for the second time, the cookie set in the previous exchange takes it through a different workflow and the application installation succeeds.
Type of change
There are two changes
https://{SHOP}/admin/apps/{SHOP_SPI_KEY}) in their admin console, we will redirect them to the authentication page (https://{APPLICATION}/auth?shop={SHOP}) of the shopify app.Until the shopify app is installed, this link
https://{SHOP}/admin/apps/{SHOP_SPI_KEY}doesn't exist and hence the installation always fails the first time. By redirecting to the authentication page, the shopify app just tries to authenticate and installation proceeds.