This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
Use SewingKitKoa Middleware in createRender #1160
Merged
+60
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Sewing Kit Koa's middleware to the
createRender
middleware in@shopify/react-server
.createRender
is already tied to the Sewing Kit Koa middleware, this just makes it so users have less to do in their Koa server/ are less likely to hit errors when trying to use it.The
createRender
middleware now accepts anassetPrefix
that is passed to thesewingKitKoa
middleware.Type of change
@shopify/react-server
Major/BreakingChecklist