Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Use SewingKitKoa Middleware in createRender #1160

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

cartogram
Copy link
Contributor

@cartogram cartogram commented Oct 30, 2019

Description

This PR adds Sewing Kit Koa's middleware to the createRender middleware in @shopify/react-server. createRender is already tied to the Sewing Kit Koa middleware, this just makes it so users have less to do in their Koa server/ are less likely to hit errors when trying to use it.

The createRender middleware now accepts an assetPrefix that is passed to the sewingKitKoa middleware.

Type of change

  • @shopify/react-server Major/Breaking

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

Copy link
Contributor

@marutypes marutypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we just need to make sure it's marked as a breaking change and that existing uses are fixed to not mount the koa middleware manually.

@cartogram cartogram merged commit db9452d into master Oct 30, 2019
@cartogram cartogram deleted the add-skk-to-cr branch October 30, 2019 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants