This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
koa-shopify-auth: update redirection page to use App Bridge action #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vividviolet
reviewed
Jan 23, 2020
| data = JSON.stringify({ | ||
| message: 'Shopify.API.remoteRedirect', | ||
| data: { location: '${redirectTo}' } | ||
| var AppBridge = window['app-bridge']; |
There was a problem hiding this comment.
Looks great, is there any tests for this util?
There was a problem hiding this comment.
Nothing for this particular script, all this file does is render a route with this script to redirect the user out of the iframe in Safari so we can set a cookie.
tylerball
force-pushed
the
koa-shopify-auth/app-bridge
branch
from
d9de78b
to
04388e7
Compare
tylerball
force-pushed
the
koa-shopify-auth/app-bridge
branch
from
04388e7
to
2116f6b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/Shopify/app-bridge/issues/1410
Type of change
This PR updates the redirection script in
koa-shopify-authto use the App Bridge Redirect action instead of a bare postMessage call. I've 🎩ed this in Safari.cc @Shopify/app-bridge
Checklist