This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
set cookies to be secure #1255
Merged
set cookies to be secure #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiedavis
force-pushed
the
try-force-cookies
branch
from
45dd87e
to
83f768c
Compare
|
Should we also change the spots we set cookies to manually use |
|
@TheMallen There's actually a great PR open here: #1251 |
katiedavis
force-pushed
the
try-force-cookies
branch
from
ddde44f
to
444e232
Compare
tylerball
reviewed
Feb 3, 2020
|
|
||
| - Package now forces cookies.secure to be true [1255](https://github.com/Shopify/quilt/pull/1255) | ||
|
|
||
| ## 3.1.55 -2020-02-02 |
There was a problem hiding this comment.
I would just release em under the same version
tylerball
approved these changes
Feb 3, 2020
katiedavis
force-pushed
the
try-force-cookies
branch
from
e5df7ca
to
8176855
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where request is not considered secure. See: https://github.com/Shopify/shopify-demo-app-node-react/issues/129#issuecomment-580820979
Type of change
Checklist