Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

✖️ deprecate react-server-webpack-plugin #1489

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

michenly
Copy link
Contributor

@michenly michenly commented Jun 3, 2020

Description

Fixes (issue #) this is the attempt to address the dependency issue between quilt_rails and react-server-webpack-plugin.

I am deprecating react-server-webpack-plugin and moving it into react-server

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality) for react-server
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@michenly michenly force-pushed the deprecate-react-server-webpack-plugin branch from 5e55c20 to 6cc2c86 Compare June 3, 2020 18:40
Copy link
Contributor

@marutypes marutypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, though I think it is missing the .js + .d.ts for adding an extra package entry.

Once that is done I guess the next step is just updating sewing-kit to consume react-server instead of react-server-webpack-plugin

@@ -0,0 +1 @@
export {ReactServerPlugin} from './webpack-plugin';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a webpack-plugin.js to the root of the package if we want to be able to get at this (see other packages with multiple sub-packages)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its already included as packages/react-server/webpack.d.ts and packages/react-server/webpack.js and reference in packages/react-server/package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thou I might rename them...

@michenly michenly force-pushed the deprecate-react-server-webpack-plugin branch 3 times, most recently from 15cf79c to 3e851e5 Compare June 3, 2020 21:11
@michenly michenly self-assigned this Jun 3, 2020
@michenly michenly force-pushed the deprecate-react-server-webpack-plugin branch 3 times, most recently from afc8d41 to a0c25c8 Compare June 4, 2020 15:20
@michenly michenly force-pushed the deprecate-react-server-webpack-plugin branch from a0c25c8 to ce25609 Compare June 4, 2020 15:46
@michenly michenly merged commit 32555e4 into master Jun 4, 2020
@michenly michenly deleted the deprecate-react-server-webpack-plugin branch June 4, 2020 17:04
@michenly michenly temporarily deployed to production June 4, 2020 20:38 Inactive
@michenly michenly temporarily deployed to gem June 8, 2020 20:47 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants