This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
EncodeURI origin app-bridge #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyfer
force-pushed
the
xss-issue-koa-auth
branch
from
50a1b76
to
2fcac74
Compare
ismail-syed
reviewed
Aug 26, 2020
ismail-syed
approved these changes
Aug 26, 2020
keyfer
force-pushed
the
xss-issue-koa-auth
branch
from
511e088
to
11dccc9
Compare
marutypes
reviewed
Aug 26, 2020
marutypes
approved these changes
Aug 26, 2020
dreamsInDigital
approved these changes
Aug 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://hackerone.shopifycloud.com/reports/966419
Encode the
originparameter to block XSS vulnerabilitiesType of change
koa-shopify-authPatch: Bug (non-breaking change which fixes an issue)Checklist