Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Parallel CI jobs #1705

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Parallel CI jobs #1705

merged 2 commits into from
Dec 10, 2020

Conversation

ismail-syed
Copy link
Contributor

Description

This PR splits up our CI checks into parallel jobs to boost CI times (shaves of a couple mins). This is also helps with CI reporting errors sooner than later since it's parallel.

Before

image

After

image

branches: [master]
pull_request:
branches: [master]
on: push
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously setup just to run CI on pushes to master, not sure why. It now runs CI on all pushes to this repo.

- name: 💅🏼 Lint
run: |
yarn lint
yarn ci:lint-docs

node-build:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to re-use all of this duplication :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem so - actions/starter-workflows#245.

I stumbled across the needs field while looking through their docs. Couldn't get it to work properly and it arguably ends up creating more duplication - 89013b8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ismail-syed
Copy link
Contributor Author

Hmm, wonder why these are hanging.

image

@ismail-syed ismail-syed force-pushed the imporve-ci-setup branch 3 times, most recently from 89013b8 to 884056f Compare December 10, 2020 16:55
@atesgoral
Copy link
Contributor

Grr we have a flaky test that got flakier after the switch to GitHub Actions somehow.

@ismail-syed
Copy link
Contributor Author

Actually, it could be a Node 14 perf thing /shrug.

Were we running node 14 in Travis?

image

@ismail-syed ismail-syed merged commit e45ba78 into master Dec 10, 2020
@ismail-syed ismail-syed deleted the imporve-ci-setup branch December 10, 2020 20:41
@gmcgibbon gmcgibbon mentioned this pull request Dec 11, 2020
1 task
@gmcgibbon gmcgibbon temporarily deployed to production December 11, 2020 21:33 Inactive
@marutypes marutypes temporarily deployed to gem February 8, 2021 15:51 Inactive
@ismail-syed ismail-syed deployed to beta-mandatory-extensions March 2, 2021 19:35 Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants