Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Update sewing-kit, babel, and jest #1948

Merged
merged 8 commits into from
Jun 21, 2021
Merged

Conversation

vsumner
Copy link
Collaborator

@vsumner vsumner commented Jun 21, 2021

Description

Update @sewing-kit/* packages which includes the latest jest and the latest babel.

I had to do some updates because setImmediate is no longer always available. I fixed this by refactoring semaphore and including it directly in magic tests.

Fixes (issue #)

Type of change

Updated packages (via yarn updated)
Patch? I didn't introduce breaking changes.

@shopify/ast-utilities
graphql-typescript-definitions
@shopify/magic-entries-webpack-plugin
@shopify/react-i18n-universal-provider
@shopify/react-i18n
@shopify/react-server
@shopify/sewing-kit-plugin-quilt

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@vsumner vsumner force-pushed the sewing-kit-update-june-2021 branch from 31be34e to b576d8f Compare June 21, 2021 14:02
@vsumner vsumner requested review from a team and dahukish June 21, 2021 14:59
@vsumner vsumner marked this pull request as ready for review June 21, 2021 15:29
@atesgoral
Copy link
Contributor

atesgoral commented Jun 21, 2021

Do you know why setImmediate is not always available? I thought it was a pretty standard browser/Node.js thing now.

Ah. https://developer.mozilla.org/en-US/docs/Web/API/Window/setImmediate It was "non-standard".

Copy link
Contributor

@atesgoral atesgoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Didn't tophat.

@vsumner vsumner merged commit e6d6b5c into main Jun 21, 2021
@vsumner vsumner deleted the sewing-kit-update-june-2021 branch June 21, 2021 17:28
@shopify-shipit shopify-shipit bot temporarily deployed to production June 22, 2021 00:30 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to gem June 23, 2021 20:18 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants