Prepare for typescript 5. Enable consistent type import formatting #2608

BPScott · 2023-03-23T03:42:25Z

Description

Preparation work to make TypeScript 5.0 and verbatimModuleSyntax easily adoptable.

Update @typescript/eslint/*, eslint-plugin-import and prettier
Enable the @typescript-eslint/consistent-type-imports, @typescript-eslint/consistent-type-exports, @typescript-eslint/no-import-type-side-effects and import/consistent-type-specifier-style lint rules.
Apply autofixes for those rules and prettier update
Some manual fixes to use import type instead of dynamic type imports

This results in us always using import type when dealing with type imports.

BPScott added 3 commits March 22, 2023 19:43

Update @typescript-eslint/*, prettier and eslint-plugin-import

a02b013

enable consistent-type-imports and apply autofixes

89f3a8a

Fix usages of dynamic type imports

c77eebf

BPScott requested a review from a team as a code owner March 23, 2023 03:42

BPScott requested a review from ryanwilsonperkin March 23, 2023 03:42

BPScott added 2 commits March 22, 2023 20:43

add changeset

1718d19

yarn dedupe

bfb85c6

BPScott merged commit ba4da84 into main Mar 23, 2023

BPScott deleted the ts5prep branch March 23, 2023 16:12

shopify-github-actions-access bot mentioned this pull request Mar 23, 2023

Version Packages #2610

Merged

BPScott mentioned this pull request Mar 23, 2023

Update to TypeScript 5.0 #2611

Merged