This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
Adds {After, Between}EachPass arguments to react-server
#911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
force-pushed
the
react-server__after-between-each-pass
branch
2 times, most recently
from
afeda4c
to
f4aac86
Compare
lemonmade
approved these changes
Aug 27, 2019
| @@ -26,12 +26,17 @@ export type RenderContext = Context & { | |||
| }; | |||
| export type RenderFunction = (ctx: RenderContext) => React.ReactElement<any>; | |||
|
|
|||
| export interface Options { | |||
| afterEachPass?(pass: Pass): any; | |||
| betweenEachPass?(pass: Pass): any; | |||
There was a problem hiding this comment.
When I am doing pass-through from another set of options, I usually try to reference their types instead (Partial<Pick<ArgumentAtIndex<typeof extract, 1>, 'afterEachPass' | 'betweenEachPass'>>) should do that here, or export its Options type to get rid of the argumentAtIndex bit)
cartogram
force-pushed
the
react-server__after-between-each-pass
branch
from
fefaf83
to
eed2731
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Optionsobject as the second argument tocreateRender()allowing passed in values forafterEachPassandbetweenEachPass#911Type of change
react-serverMinor: New feature (non-breaking change which adds functionality)Checklist