Improve renderComponent() utility in React to make "position in tree" restrictions a little easier #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonmade
commented
Mar 31, 2022
| @@ -38,6 +39,7 @@ export interface RemoteReceiverAttachableFragment | |||
|
|
|||
| export interface RemoteReceiverAttachableRoot { | |||
| id: typeof ROOT_ID; | |||
| kind: typeof KIND_ROOT; | |||
There was a problem hiding this comment.
components and texts both had kinds, but roots did not. This adds it so that kind is a good type discriminate when working with the remote tree on the host side.
| @@ -18,22 +19,6 @@ import type { | |||
|
|
|||
| const emptyObject = {}; | |||
|
|
|||
| export function renderComponent({ | |||
There was a problem hiding this comment.
I found the flow of imports really confusing here — RemoteComponent defined this function, which was imported by controller, but also used implicitly by controller.renderer.renderComponent calls later in this same file. I moved this implementation to be inlined in controller, which was the only place it was used anyways.
kumar303
approved these changes
Apr 1, 2022
|
@kumar303 there were only some e2e tests, but I added in a few more for these behaviors 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field to the
renderComponent()function we introduced in #86. The new field isparent, which gives the host the ability to easily customize behavior based on what other component is rendering this one. This is particularly useful if you want to enforce some components being allowed as direct children of the remote root, and others only being allowed if they are nested below the root.We never added documentation to
renderComponent(), so I have done that here.cc/ @js-goupil this adds what I think is the missing piece for easily implementing more advanced component restrictions on the host, if you are interested in doing that instead of a multi-extension point setup.