"Extract Variable" refactor variable rename does not work

[machty]

Ruby version

3.2.1

Code snippet

send challenges.sample

Description

When I select and extract "challenges.sample", it successfully extracts "new_variable" and selects it so that I can provide the variable name, but when I update the variable name, it only updates one variable name reference and not the other. Video demo:

extract_variable_bug.mp4

Expected output

See description

[vinistock]

Thank you for the report! We haven't implemented the rename request yet #57, that's why it doesn't show up when extracting a variable.

This will be supported as soon as that issue is completed.

[machty]

I think you could implement this without invoking the full machinery of the future Rename refactor... you just need to highlight / multi-cursor new_variable.

[vinistock]

I think that would require returning a snippet from the refactor code action is which currently not supported by the LSP spec.

See microsoft/language-server-protocol#592 and microsoft/language-server-protocol#724.