fix encoding of MetadataResponse with version >= 2 #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrottleTimeMs and ClusterID have been added to decode(), but apparently encode() was forgotten. This causes errors in tests, if versions >= 2 are used.
channels success and errors are not guaranteed to be closed before the channel closed is closed. some tests, .e.g. TestProducerWithCheckerFunction relied on this assumption, and produced race conditions (e.g. len(errors) is called after producer.Close. with this change, close(mp.closed) is moved to the defer call, after closing successes and errors.
|
@bai I fixed a race in the mock async producer, unrelated to this PR. should i move it to a separate PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThrottleTimeMs and ClusterID have been added to decode(), but apparently
encode() was forgotten. This causes errors in tests, if versions >= 2 are used.