Support new OffsetFetch request/response #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bai At the Kafka Summit last week, we had a chat with @sam-obeid. We are interested in contributing regularly to this project and we are wondering if you'd consider adding new maintainers/committers. |
ghost
added
the
Co-authored-by: Edoardo Comar <[email protected]> Co-authored-by: Mickael Maison <[email protected]>
Co-authored-by: Mickael Maison <[email protected]> Co-authored-by: Edoardo Comar <[email protected]>
mimaison
force-pushed
the
offset-fetch-new-vers
branch
from
6b7467f
to
6c7918e
Compare
|
@bai I've just rebased this PR on master. Can you have a look? Thanks! |
bai
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for OffsetFetch up to version 5 (v5 is added in Kafka 2.1).
We were especially interested in v2, which allows to query offsets for all partitions used by a group instead of explicitly passing the partitions but adding the extra versions was straight forward (very few new arguments).