Revert to individual msg retries for non-idempotent #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also do idempotent batch retries in a goroutine. This avoids the deadlock but does not solve a race that can lead to out-of-sequence errors. Idempotent producer is at proof-of-concept quality Co-authored-by: Edoardo Comar <[email protected]> Co-authored-by: Mickael Maison <[email protected]>
ghost
added
the
Closed
|
Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1187
Also do idempotent batch retries in a goroutine. This avoids the deadlock but does not
solve a race condition that can lead to out-of-sequence errors.
Idempotent producer is at proof-of-concept quality
Co-authored-by: Edoardo Comar [email protected]
Co-authored-by: Mickael Maison [email protected]