Add Topics() and Partitions() to Consumer interface, and mock Consumer implementation. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Partitions returns the sorted list of all partition IDs for the given topic. | ||
| // This methods delegates to the internal Client instance. | ||
| Partitions(topic string) ([]int32, error) |
There was a problem hiding this comment.
Rather than mention delegation (technical aspect) mention that they are "the same as" and "provided for convenience" or something (UX aspect).
|
Doc string comment, but otherwise LGTM |
wvanbergen
force-pushed
the
consumer_topics_partitions
branch
from
74f0fdb
to
2052bd9
Compare
wvanbergen
added a commit
that referenced
this pull request
Apr 20, 2015
Add Topics() and Partitions() to Consumer interface, and mock Consumer implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow you to implement most consumer use cases without a
Clientinstance, and make them easier to test by adding them to the Consumer mock and allowing to stub values.As discussed in #430, fixes #366. @Shopify/kafka