Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation process fails in iOS webview with token exchange strategy for shopify-app-remix #714

Open
5 tasks done
zakariamofaddel opened this issue Mar 26, 2024 · 4 comments
Assignees
Labels

Comments

@zakariamofaddel
Copy link

Issue summary

Before opening this issue, I have:

  • Upgraded to the latest version of the package
    • @shopify/shopify-app-* package and version:
    • Node version:
    • Operating system:
  • Set { logger: { level: LogSeverity.Debug } } in my configuration, when applicable
  • Found a reliable way to reproduce the problem that indicates it's a problem with the package
  • Looked for similar issues in this repository
  • Checked that this isn't an issue with a Shopify API

Expected behavior

The installation flow completes successfully on iOS Shopify app webview.

Actual behavior

During the installation process the auth.$ remix route is called and in turn it calls await authenticate.admin(request);, the flow reaches then the respondToBouncePageRequest and it throws a Response containing the script that should load AppBridge from https://cdn.shopify.com/shopifycloud/app-bridge.js.
This is where the flow gets interrupted and I am not able to debug any further.

Steps to reproduce the problem

  1. Create a Shopify app using the remix template
  2. Install on development store from Desktop computer and then uninstall the app.
  3. Now using an iOS device go to the Shopify mobile app -> Settings -> Apps and Sales channels -> Uninstalled and install the app.
@pobed2
Copy link
Contributor

pobed2 commented Apr 17, 2024

Thank you for reporting this! We were able to reproduce on our side and we'll look at fixing this in the near future.

Copy link
Contributor

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

@zzooeeyy
Copy link
Contributor

Mobile vs desktop uninstall behaviour

desktop.mp4
mobile.MP4

Copy link
Contributor

github-actions bot commented Sep 9, 2024

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

@github-actions github-actions bot added the Stale label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants