Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failure when upgrading to Latest Shopify API #793

Open
1 task done
Praveen2106 opened this issue Apr 15, 2024 · 5 comments
Open
1 task done

Build Failure when upgrading to Latest Shopify API #793

Praveen2106 opened this issue Apr 15, 2024 · 5 comments
Labels

Comments

@Praveen2106
Copy link

Praveen2106 commented Apr 15, 2024

Issue summary

After upgrading from Shopify API 8.1.1 to 9.7.1, the following errors occur while building the application.

node_modules/@shopify/shopify-api/runtime/crypto/crypto.d.ts:1:23 - error TS2688: Cannot find type definition file for '@cloudflare/workers-types'.

1 /// <reference types="@cloudflare/workers-types" />

node_modules/@shopify/shopify-api/runtime/http/types.d.ts:1:23 - error TS2688: Cannot find type definition file for '@cloudflare/workers-types'.

1 /// <reference types="@cloudflare/workers-types" />

However, no issues with "npm run dev". The application runs without any issues.

  • Upgraded to the latest version of the relevant packages
    • "@shopify/shopify-api": "^9.7.1"
    • "@shopify/shopify-app-express": "^4.1.1"
    • "@shopify/app": "^3.58.2"
    • "@shopify/cli": "^3.58.2"
    • Node version: 18.8.2
    • Operating system: Windows 10

Are there any changes needed when upgrading to the latest version? We could not find any documentation for the same,

@lizkenyon
Copy link
Contributor

Hi there 👋

Could you share what your package.json looks like?

@Praveen2106
Copy link
Author

I've attached the package.json file below. Kindly let me know if you need anything else. Thanks!

package.json

@eyoeldefare
Copy link

They seem to break everything every time they upgrade their libraries. Look at their libraries, its barely production grade.

@Praveen2106
Copy link
Author

I upgraded to 9.7.2 and this issue is not found now. But from the changes, I could not see what fixed this.

Copy link
Contributor

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

@github-actions github-actions bot added the Stale label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants