Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there plans for an update? #701

Closed
jsullivan5 opened this issue Feb 10, 2022 · 5 comments · Fixed by #707
Closed

Are there plans for an update? #701

jsullivan5 opened this issue Feb 10, 2022 · 5 comments · Fixed by #707

Comments

@jsullivan5
Copy link
Contributor

Issue summary

I'm reading issues across here and in the supporting libraries that people's apps are being denied due to an old shopify api version used in koa-shopify-auth. It also seems like after the move to session tokens a lot of this scaffolding is no longer needed.

Is there an update coming here?

This has been super helpful to get started quickly but it seems like this won't pass listing approval unless we use community forked and updated core packages or do something else entirely at the moment.

There are alternatives and fixes out there but having something with Shopify support would be awesome.

Expected behavior

Apps built with this should be eligible for App Store listing

Actual behavior

Apps are being denied due to an old API version built into koa-shopify-auth.

@Michael-Gibbons
Copy link

@jsullivan5 I believe Shopify is doing a full rebuild of this framework, removing koa in leu of express, and removing NextJS. They seem to be intentionally not responding to the issues publicly because frankly, they know its unacceptable to release a tool the products of which aren't even eligible for their own app store but responding and admitting fault when they've wasted hundreds of thousands of dollars in development time likely doesn't make the company look too good.

I have much sympathy for the developers and contributors of these packages as I'm sure they are incredibly smart people who just have too much on their plate, as well as internal plans we don't have vision on. The blame is on Shopify for not investing enough resources into their tools, its just unfortunate that the consequences of those choices have been passed onto the app developers and our clients.

@Michael-Gibbons
Copy link

@jsullivan5 The issue you mentioned has been fixed in Shopify/koa-shopify-auth#144

@jsullivan5
Copy link
Contributor Author

Thanks @Michael-Gibbons! I poked around the use-express branch here and it looks like that's moving along. Good to hear the current iteration is updated as well.

I'm just starting with this app and new to the ecosystem. It seems like a lot of sweeping changes are coming here for the better. Have you come across any good alternatives or think it's best to move forward and lift and shift later as needed?

@Michael-Gibbons
Copy link

@jsullivan5 if you're new to the ecosystem the boilerplate is still very good to get up and running. At this moment if you're around senior level it might be more prudent to make your own boilerplate until the express version is released. The main linchpins right now are nextjs, koa, and apollo. NextJS is frankly not required and overcomplicates things, koa isn't as supported as express, and the apollo packages need to be updated to use @apollo/client. So if you can avoid those packages you should jump the main hurdles in this boilerplate.

@danielbixel
Copy link

danielbixel commented Feb 19, 2022

Would be great to have a working boilerplate to start with.
Updates have been announced since a couple off months already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants