This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Add shopify-dev link to suggestion title #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmanzella
force-pushed
the
icc-title-links
branch
from
427eac9
to
365bcf2
Compare
karreiro
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #699
Summary
Tophatting
Open a theme and test the following scenarios. Type the following and at the cursor type Ctrl-Space. When a suggestion appears, click the title link. Confirm the link is a sensible suggestion for what you typed. Object properties can be deep linked but tag parameters cannot
Object
{{ address█ }}Object property
{{ address.cit█ }}Tag
{% if█ %}Filter
{{ cart | external_video_tag█ }}Filter parameter
TODO -- I can't seem to find an example for this case where we suggest a filter parameter?