Skip to content
Compare
Choose a tag to compare
@github-actions github-actions released this 27 Mar 19:50
· 107 commits to main since this release
8447311

Minor Changes

  • 767d223: Breaking: Redesign jsonValidationSet public API

    (Only breaking for in-browser packages, node packages are still batteries-included)

    Before:

    type JsonValidationSet = {
      sectionSchema(): Promise<string>;
      translationSchema(): Promise<string>;
      validateSectionSchema(): Promise<ValidateFunction>;
    };

    After:

    type URI = string;
    
    type SchemaDefinition = {
      uri: string;
      fileMatch?: string[];
      schema: Promise<string>;
    };
    
    type JsonValidationSet = {
      schemas: SchemaDefinition[];
    };

    We’re getting rid of ajv and we’ll use vscode-json-languageservice in Theme Check instead. That dependency is required by the language server anyway, might as well reuse it instead of depending on a totally different solution for validation. We'll also get better reporting of Syntax Errors because the parser used by vscode-json-languageservice is better.

    Moreover, this new design leaves space for $ref support.

Patch Changes