Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying CalendarEventData #38

Closed
b-scharbau opened this issue Feb 14, 2022 · 1 comment · Fixed by #37
Closed

Modifying CalendarEventData #38

b-scharbau opened this issue Feb 14, 2022 · 1 comment · Fixed by #37

Comments

@b-scharbau
Copy link
Contributor

I currently had the problem that I wanted to modify an existing event entry (in particular change start and end time). However, I did not find an option to modify existing events in this library, so I went with the solution to delete the event from the EventController first, and then add it again, with modified values.

However, during this approach, I noticed that the event is not correctly deleted from the controller, but still remains stored in the _eventList variable, where it leads to the event supposed to be deleted being represented multiple times in the DayView after subsequent modifications (which then call remove on the controller).

@b-scharbau
Copy link
Contributor Author

I made a PR (#37) addressing this issue, but I think the comparison algorithm might be improved upon here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants