Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from pybind11 to nanobind #340

Closed
ManifoldFR opened this issue Jul 18, 2024 · 4 comments · Fixed by #345
Closed

Move from pybind11 to nanobind #340

ManifoldFR opened this issue Jul 18, 2024 · 4 comments · Fixed by #345
Assignees
@ManifoldFR
Labels
enhancement New feature or request

Comments

@ManifoldFR
Copy link
Member

After discussing with @jorisv, we think that upgrading from pybind11 to nanobind for proxsuite would be beneficial and an opportunity to cut our teeth on this newer bindings library, see what works, what doesn't, and what's easier to do now.
@ManifoldFR ManifoldFR added the enhancement New feature or request label Jul 18, 2024
@jcarpent
Copy link
Member

Looks perfect to me. Thanks @ManifoldFR for this suggestion.

@ManifoldFR ManifoldFR self-assigned this Aug 5, 2024
@ManifoldFR
Copy link
Member Author

ManifoldFR commented Aug 5, 2024 •
edited
Loading

Took this afternoon to work on this. The bindings compile atm, still have something to do with respect to the CMake install step.

@ManifoldFR ManifoldFR mentioned this issue Aug 5, 2024
Merged
3 tasks
@stephane-caron
Copy link
Contributor

Nice initiative! When it is ready we could run the qpbenchmark test sets 1, 2, 3 to do a pybind11/nanobind comparison of computation times.

@jcarpent
Copy link
Member

jcarpent commented Sep 2, 2024

Solve via #345.

@jcarpent jcarpent closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManifoldFR ManifoldFR

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move from Pybind11 to nanobind ManifoldFR/proxsuite
3 participants
@stephane-caron @jcarpent @ManifoldFR