Fix mu_update for PrimalLDLT backend
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabinsch
force-pushed
the
topic/fix-ldlt
branch
2 times, most recently
from
637a700
to
8105f4a
Compare
jcarpent
reviewed
Aug 21, 2024
jcarpent
previously approved these changes
Aug 21, 2024
jcarpent
force-pushed
the
topic/fix-ldlt
branch
from
8105f4a
to
c5f734b
Compare
Co-authored-by: Justin Carpentier <[email protected]>
jcarpent
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as pointed out in #348, there is currently a mismatch when calling the
rank_r_update.I discussed it with @Bambade, and we propose this PR to fix it, and correct another typo that was found while analyzing the function.
We also add the example from #348 as a new unittest for the
PrimalLDLTbackend, where we trigger amu_update.