Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denormalize is missing in eval_long #14

Open
Kairobo opened this issue Oct 31, 2024 · 6 comments
Open

denormalize is missing in eval_long #14

Kairobo opened this issue Oct 31, 2024 · 6 comments

Comments

@Kairobo
Copy link

Kairobo commented Oct 31, 2024

No description provided.

@kleinzcy
Copy link

kleinzcy commented Nov 1, 2024

Same issue.

When you have time to open-source the evaluation of long-term generation?

@Sirui-Xu
Copy link
Owner

Sirui-Xu commented Nov 1, 2024

Hello,

Here’s the code for denormalizing and evaluation: link to code. It’s not fully organized yet but should produce the same results as reported in the paper.

Will find a time to complete the wrap-up for this part and integrate it into the current codebase.

Best

@kleinzcy
Copy link

kleinzcy commented Nov 1, 2024

Thanks for your code. The provided evaluation code contains the denormalize function. But the evaluation is still failed as it missing "correct" function (Line 314 in eval_smpl_long.py).

@kleinzcy
Copy link

kleinzcy commented Nov 1, 2024

Another question. It takes 10 minutes for 1 epoch on the TITAN RTX. Is it normal? And it occures oserror when num_workers > 0. How do you fix such error?

@Sirui-Xu
Copy link
Owner

Sirui-Xu commented Nov 1, 2024

The ‘correct’ function should be ‘smooth’ as defined in the short-term evaluation code, sorry for the confusion

I don’t recall encountering similar cases before in a Linux environment with A40 or TITAN X. The network and dataset are lightweight and should train very quickly.

@kleinzcy
Copy link

kleinzcy commented Nov 1, 2024

Thanks for your help. However, the evaluation still failed as the get_batch function is not right. The repeat dimension is not right. I have tried, but not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants