Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line comments #2180

Closed
Wealthyturtle opened this issue Jun 20, 2019 · 5 comments
Closed

Multi-line comments #2180

Wealthyturtle opened this issue Jun 20, 2019 · 5 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Wealthyturtle
Copy link
Member

Description

At the moment, you can only use single-line comments (declared with #) that will make any text after it part of a comment. My suggestion is to be able to "terminate" a comment, e.g.

set {_i} to dirt named "&6Dirt" #TODO# enchanted with unbreaking 1

Which would allow for comments to be inserted within lines of Skript, rather than on a separate line or to the end of the line

Similarly, multi-line comments would also solve this issue, and also allow people to comment out large chunks of Skript.

Although the parsing for this may be problematic, I think it'll certainly help out Skript users working on large projects :)

@FranKusmiruk
Copy link
Member

FranKusmiruk commented Jun 22, 2019

Although the parsing for this may be problematic

It might not be the case but still, do we really need this? There's a ton of languages that handle comments just like Skript does and I've never seen it as a big deal.

What I am saying is just that I am unable to see the advantages of this, if anything, multi-line comments would be a more viable option.

@Wealthyturtle
Copy link
Member Author

Yeah, multiline comments would work great too lol

@Moderocky
Copy link
Member

Personally, I do see having an end-comment-tag as being a useful feature but would much prefer multi-line support for comments as well.
It's a pain to have to comment every line with a # when you want to comment out a section.

@TheBentoBox TheBentoBox added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jul 8, 2019
@TheBentoBox
Copy link
Member

Will mark as an enhancement for the sake of multiline comments.

@Wealthyturtle Wealthyturtle changed the title Comment Enhancements Multi-line comments Oct 17, 2019
@ShaneBeee ShaneBeee mentioned this issue Nov 7, 2020
@Forcinq
Copy link

Forcinq commented Feb 13, 2022

can we still do this :)

@Moderocky Moderocky added the PR available Issues which have a yet-to-be merged PR resolving it label Apr 12, 2024
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

6 participants