Item comparisons are too specific

[wallxq]

Description

I have updated Skript to the latest version and noticed that a certain function stopped working for me.
I migrate from 2.5 alpha5.

Steps to Reproduce

https://pastebin.com/mFVyYpec

Expected Behavior

I created just any script. Anything should happen. I want to show that any item that has its name changed color is undetectable.

Errors / Screenshots

There are no erros.

Server Information

I use Paper 1.16.4 version 318 with AdoptOpenJDK 11 HotSpot
I tested on skript 2.5.1 and 2.5.2. There is the same problem on both versions.

[ShaneBeee]

I tested your code, both worked fine for me:

[wallxq]

I already know what the problem is. Skript does not detect item by name if item has lore or uses flags to hide for example "attributes". In the old version of skript, there was no problem with this.

[APickledWalrus]

Skript is explicitly checking for a diamond sword with the given name. If there are any other modifiers, the check will fail. I think you are meaning to check the name specifically. If so, you could do:

if the name of the event-item is "&6Sword +0":

[wallxq]

Skript is explicitly checking for a diamond sword with the given name. If there are any other modifiers, the check will fail. I think you are meaning to check the name specifically. If so, you could do:

if the name of the event-item is "&6Sword +0":

That works! Thanks you 👍

[wallxq]

Okay but what if item is in inventory?
if player has 1 diamond sword named "&6Sword +0" with custom model data 81:
or
if player has 1 diamond sword named "&6Sword +0":
don't work, no errors

[APickledWalrus]

Are you sure the item doesn't have any other modifiers? It has to match exactly. If you aren't able to check for the specific items, you could loop through the player's inventory items and compare the type and name of each item to determine if it is a match.

[wallxq]

The point is that I have quite complicated items that I wanted to easily extract and capture in a script. When upgrading, skript no longer works "named" or "has". Now I'm forced to loop all inventory and use "if name".

[APickledWalrus]

Recently changes were made to how item comparison works. A lot of previous behavior that did work no longer does, as it wasn't intentional. I could be wrong about how this is supposed to work though, so I'll leave this open for input from the other developers.

[wallxq]

I believe this has more harm than good in it. This makes it a bit more difficult. For me, it means that I have to change a lot now and I have what because it is a few MB of scripts for over 400 players.

[APickledWalrus]

Okay so, after some investigating and discussion, I was mistaken. This actually should work if the "second" item has at least the properties of the "first" item. Having more is okay. To explain that with an actual example:

player's tool = diamond sword of sharpness 1 named "Sharp Sword"

if the player's tool is a diamond sword of sharpness 1: # SHOULD WORK
if a diamond sword of sharpness 1 is the player's tool: # SHOULD NOT WORK - this is because the player's tool also has a name.

I think this is how it used to work, but the behavior was broken after a change to item comparisons.

[wallxq]

I noticed another problem. Many plugins make items easy. Like here:
{display: {Name: '{"text": "Blood Pearl"}'}, CustomModelData: 103}

After saving such an item to a variable and checking it with has item, it works fine.
The problem occurs after a server restart. The item written in the variable becomes:
{display: {Name: '{"extra": [{"bold": true, "italic": false, "underlined": false, "strikethrough": false, "obfuscated": false, "color": "gold "," text ":" Blood Pearl "}]," text ":" "} '}, CustomModelData: 103}
Which means that an item created by plugins is not recognized by has item. Even more strange, if the player re-enters the server, the item will get similar values ​​and only then has the item work.

[wallxq]

It would be great if script could compare these two items to each other because they are actually the same without looking at the metadata.

[wallxq]

Paper converting the json color to the "another" color system after reconnect player or restart server. It would be good if Skript could recognize item only through custom model data. Because in the current case of using "if player has" he wants 1 to 1 to be accurately given the whole.

[wallxq]

if items in player's inventory contains its i think addon?
Works as it should "if player has item".