Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the hex color tag is set to a variable, it does not work. #4276

Closed
1 task done
vhone opened this issue Aug 14, 2021 · 1 comment
Closed
1 task done

If the hex color tag is set to a variable, it does not work. #4276

vhone opened this issue Aug 14, 2021 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@vhone
Copy link

vhone commented Aug 14, 2021

Skript/Server Version

[Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[Skript] Server Version: git-Paper-127 (MC: 1.17.1)
[Skript] Skript Version: 2.6-beta2-nightly-5a6633f
[Skript] Installed Skript Addons:

Bug Description

If the hex color tag is set to a variable, it does not work.

It worked fine in the previous version. and It doesn't work in latest version.
The latest nightly version doesn't work either. so report it

Expected Behavior

As well as variables, using the 'colored' expression does not work properly.

Steps to Reproduce

command /chat.color:
    trigger:
        send "<##00ff00>█"
        send colored "<##00ff00>█"
        set {_value} to "<##00ff00>█"
        send {_value}
        send colored {_value}
        send uncolored {_value}

Errors or Screenshots

2021-08-14_15 55 11

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Aug 14, 2021
@APickledWalrus
Copy link
Member

Issue is that the color is likely being set to the color corresponding to the last character in that HEX string (&0 aka black as seen in the photo). HEX is very annoying to parse, especially due to it's weird format. This likely occurs within the parsing of Utils#replaceChatStyles.

@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

3 participants