Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] - Reorganize Skript's packages #4326

Open
1 task done
Olyno opened this issue Sep 10, 2021 · 1 comment
Open
1 task done

[suggestion] - Reorganize Skript's packages #4326

Olyno opened this issue Sep 10, 2021 · 1 comment
Assignees
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@Olyno
Copy link
Contributor

Olyno commented Sep 10, 2021

Suggestion

After trying to work on Skript, i found it really annoying to have every expressions in the same dir. We can't find what we're looking for easily. That's why i'm suggesting to create some subpackages like "players" and move expressions related to the packages directly there.

Why?

I found the project was becoming a mess with all expressions, effects.... and new ones coming in the future.

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this suggestion.
@Mwexim
Copy link
Contributor

Mwexim commented Sep 12, 2021

In addition to this, I feel like a lot of simple property expressions could be registered directly without needing a separate class.

Something like PropertyExpression.registerSimpleProperty() that uses a default implementation could be used for that.

@TPGamesNL TPGamesNL added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 12, 2021
@TheLimeGlass TheLimeGlass added this to the 2.7 milestone Feb 2, 2022
@APickledWalrus APickledWalrus removed this from the 2.7 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

5 participants