Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast effect errors on 1.9-1.11 #4951

Closed
1 task done
TPGamesNL opened this issue Jul 24, 2022 · 1 comment
Closed
1 task done

Broadcast effect errors on 1.9-1.11 #4951

TPGamesNL opened this issue Jul 24, 2022 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@TPGamesNL
Copy link
Member

Skript/Server Version

2.6.3, Spigot 1.10

Bug Description

Using the broadcast effect with a VariableString (or formatted expr) will throw an NoSuchMethodError for CommandSender#spigot

Expected Behavior

Not to error

Steps to Reproduce

broadcast "abc"

Errors or Screenshots

No response

Other

CommandSender#spigot was introduced in 1.12, but Skript doesn't include checks for this. Solution would probably be to make EffBroadcast more like EffMessage.

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 labels Jul 24, 2022
@APickledWalrus APickledWalrus mentioned this issue Jul 26, 2022
Closed
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jul 26, 2022
@TheLimeGlass
Copy link
Collaborator

Duplicate #5019

@TheLimeGlass TheLimeGlass removed the PR available Issues which have a yet-to-be merged PR resolving it label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheLimeGlass @APickledWalrus @TPGamesNL