Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn Falling Block throws NPE #5042

Closed
1 task done
NotSoDelayed opened this issue Aug 23, 2022 · 2 comments
Closed
1 task done

Spawn Falling Block throws NPE #5042

NotSoDelayed opened this issue Aug 23, 2022 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@NotSoDelayed
Copy link
Contributor

Skript/Server Version

[03:12:54 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[03:12:54 INFO]: [Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[03:12:54 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[03:12:54 INFO]: [Skript] Server Version: git-Paper-81 (MC: 1.19)
[03:12:54 INFO]: [Skript] Skript Version: 2.6.3
[03:12:54 INFO]: [Skript] Installed Skript Addons:
[03:12:54 INFO]: [Skript]  - skript-yaml v1.4
[03:12:54 INFO]: [Skript]  - reqn v1.3.0-alpha
[03:12:54 INFO]: [Skript]  - skript-reflect v2.3 (https://github.com/TPGamesNL/skript-reflect)
[03:12:54 INFO]: [Skript]  - SkBee v2.1.0 (https://github.com/ShaneBeee/SkBee)
[03:12:54 INFO]: [Skript] Installed dependencies: None

Bug Description

Using EffSecSpawn to spawn a Falling Block throws NPE.

Expected Behavior

Does not throws NPE, and perhaps default to falling block of Sand Block as in pre-1.13 is called falling_sand after all.

Steps to Reproduce

Code used: spawn falling block at player

Errors or Screenshots

image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@NotSoDelayed
Copy link
Contributor Author

Further testing shows that spawning a falling block with SkBee's NBT throws the exact same error.
Code used: spawn falling block with nbt compound of "{BlockState:{Name:""minecraft:sand""},Time:1,DropItem:0b,HurtEntities:0b}"

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Aug 24, 2022
@TPGamesNL
Copy link
Member

As a workaround, specify the type of falling block, e.g. falling stone.

FallingBlockData#types is nullable, but the spawn method doesn't deal with this properly.

@AyhamAl-Ali AyhamAl-Ali added the PR available Issues which have a yet-to-be merged PR resolving it label Aug 27, 2022
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

4 participants