Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading all scripts returns green when errors are encountered #6425

Open
1 task done
EquipableMC opened this issue Feb 12, 2024 · 1 comment
Open
1 task done

Reloading all scripts returns green when errors are encountered #6425

EquipableMC opened this issue Feb 12, 2024 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@EquipableMC
Copy link
Contributor

Skript/Server Version

[16:08:36 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[16:08:36 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[16:08:36 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[16:08:36 INFO]: [Skript] Server Version: git-Purpur-2140 (MC: 1.20.4)
[16:08:36 INFO]: [Skript] Skript Version: 2.8.2 (skriptlang-github)
[16:08:36 INFO]: [Skript] Installed Skript Addons: 
[16:08:36 INFO]: [Skript]  - skript-placeholders v1.6.0 (https://github.com/APickledWalrus/skript-placeholders)
[16:08:36 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[16:08:36 INFO]: [Skript]  - DiSky v4.12.2-beta1
[16:08:36 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[16:08:36 INFO]: [Skript]  - SkBee v3.2.1 (https://github.com/ShaneBeee/SkBee)
[16:08:36 INFO]: [Skript]  - SkLogs v1.0.0 (https://github.com/EquipableMC/SkLogs)
[16:08:36 INFO]: [Skript] Installed dependencies: 
[16:08:36 INFO]: [Skript]  - Vault v1.7.3-b131
[16:08:36 INFO]: [Skript]  - WorldGuard v7.0.9+5934e49

Bug Description

When you run /sk reload /foldername/, the green text appears for scripts in, when it should be red since errors were encountered.

Expected Behavior

It's meant to be red.

Steps to Reproduce

Create a folder in skript/scripts
put some broken code in it
run /sk reload /foldername/
green text should appear

Errors or Screenshots

http://cdn.equipable.xyz/u/t5cDGo.png

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@EquipableMC EquipableMC closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@EquipableMC EquipableMC reopened this Feb 12, 2024
@AyhamAl-Ali
Copy link
Member

This PR #6150 solved it but it wasn't the best solution. IMO there should be 2 language entires for successfull reloading and failure.

@AyhamAl-Ali AyhamAl-Ali added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

2 participants