Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Channel / Update Checker logic not handling betas properly #6714

Closed
1 task done
EquipableMC opened this issue May 21, 2024 · 1 comment
Closed
1 task done
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@EquipableMC
Copy link
Contributor

Skript/Server Version

[16:55:10 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[16:55:10 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[16:55:10 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[16:55:10 INFO]: [Skript] Server Version: git-Purpur-2174 (MC: 1.20.4)
[16:55:10 INFO]: [Skript] Skript Version: 2.9.0-beta1 (skriptlang-github)
[16:55:10 INFO]: [Skript] Installed Skript Addons: None
[16:55:10 INFO]: [Skript] Installed dependencies: None

Bug Description

When you load Skript 2.9.0-beta1, it tells you to update skript which sends the same exact jar you're using

Expected Behavior

not send it

Steps to Reproduce

download skript 2.9.0-beta1
put it in plugins folder
start server

Errors or Screenshots

image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth
Copy link
Member

Yeah known issue due to hacky workaround to classify the beta as a pre-release in the update checker's eyes. I'll leave this open as a reminder to fix the update checker/release channel logic, though.

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels May 21, 2024
@sovdeeth sovdeeth changed the title Skript Update Error Release Channel / Update Checker logic not handling betas properly May 21, 2024
@sovdeeth sovdeeth added PR available Issues which have a yet-to-be merged PR resolving it patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels May 31, 2024
@sovdeeth sovdeeth closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

2 participants