Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Removal of Items w/ ArmorTrim aliases #111

Open
ShaneBeee opened this issue Apr 2, 2024 · 4 comments
Open

[Suggestion] Removal of Items w/ ArmorTrim aliases #111

ShaneBeee opened this issue Apr 2, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ShaneBeee
Copy link
Contributor

I would like to suggest the removal of the aliases for items with armor trims.
To start:

[Skript] Loaded 232659 aliases in 4296ms # default
[Skript] Loaded 197964 aliases in 2638ms # without armor trim
  • nearly 35k aliases just for items with armor trims
    • thats 15% of all aliases
    • thats added pressure on the server
    • if Minecraft adds more, this is going to get even more out of hand
    • most people don't know and/or will ever know about these aliases and/or how to guess them
  • Minecraft allows for registering custom armor trims, these hardcoded values just hurt that process
  • These don't really flow with the rest of the aliases. It would be the equivalent of having aliases for every variation of an item with enchantments. Items with applied armor trims are not found in the game by default nor are they in the creative menu, its something the player applies with a smithing table.
@sovdeeth sovdeeth added the enhancement New feature or request label Apr 2, 2024
@sovdeeth
Copy link
Member

sovdeeth commented Apr 2, 2024

I'd be in favor of this.

@Moderocky
Copy link
Member

Absolutely agree, we're planning to start deprecating aliases as of 2.9 anyway and moving towards and optional (opt-in) model in future.

@Fusezion
Copy link

Fusezion commented Apr 2, 2024

Could be made into the same system used for potions +1

@Moderocky
Copy link
Member

moving towards and optional (opt-in) model in future.

Our preliminary idea is to cut these out and provide an armor-trims.sk that people can drop in to restore the current usage. The same can probably be done for other (problematic) alias groups, before the complete removal.

@Moderocky Moderocky added the help wanted Extra attention is needed label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants