Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to translate "Search terms" in autocomplete? #409

Closed
shazul opened this issue Apr 26, 2017 · 3 comments
Closed

Question: How to translate "Search terms" in autocomplete? #409

shazul opened this issue Apr 26, 2017 · 3 comments
Labels

Comments

@shazul
Copy link

shazul commented Apr 26, 2017

Magento Version : CE 2.1.6
ElasticSuite Version : 2.3.0
Environment : Developer and Production

This is actually a question, and probably not a bug:
I've been unsuccesfully trying to translate the block titles in the autocomplete results: Search terms, Products, Categories.

I have tried adding them to my theme csv translations file (dictionary.csv) which is where I think they should be. Just to try I also addes them to the js translation (No success). Please excuse me if I'm just doing something wrong, I just can't figure out how to translate those "words".

@romainruaud
Copy link
Collaborator

Hello,

I can confirm this one is a bug, I am not able to get the translations working properly in my testing environment either.

We will try to provide a fix soon.

Best regards

@romainruaud
Copy link
Collaborator

romainruaud commented Apr 27, 2017

The translate="true" node was missing into the DI for the "Search terms" title.

But the other have this tag and does not get translated properly either.

I think that the translate="true" into Magento DI has no effect : they are not using in the core.

I asked Magento how this is supposed to work : magento/magento2#9411

But I guess we will have to refactor slightly this part.

We keep you in touch

@afoucret
Copy link
Contributor

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants