Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong install statement in CmakeLists.txt #4

Open
maxirmx opened this issue Jul 14, 2021 · 0 comments · May be fixed by #5
Open

Wrong install statement in CmakeLists.txt #4

maxirmx opened this issue Jul 14, 2021 · 0 comments · May be fixed by #5

Comments

@maxirmx
Copy link

maxirmx commented Jul 14, 2021

In https://github.com/Snaipe/fmem/blob/master/CMakeLists.txt

Shall be
install(FILES
${PROJECT_BINARY_DIR}/gen/fmem.h
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

and not

install(FILES
fmem.h
${PROJECT_BINARY_DIR}/gen/fmem-export.h
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

This issue is generalization of #3
maxirmx referenced this issue in tamatebako/fmem Jul 18, 2021
@maxirmx
Fix fmem.h installation issue
bdce276 
Snaipe#3 
Snaipe#3
@maxirmx maxirmx linked a pull request Jul 18, 2021 that will close this issue
Open
Kreijstal referenced this issue in Kreijstal/fmem Nov 11, 2023
@kris-jusiak
Merge pull request #4 from rafaelBauer/master
0a19b25 
Added static linking flags for MSVC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fmem.h installation issue tamatebako/fmem
1 participant
@maxirmx