Skip to content

Commit

Permalink
Adds case statement for ObjectTypeUser in ShowObjectParameter.
Browse files Browse the repository at this point in the history
  • Loading branch information
cmonty-paypal committed Apr 9, 2024
1 parent 5ac2759 commit 57c6953
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/acceptance/testing.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const (
TestSchemaName = "terraform_test_schema"
TestWarehouseName = "terraform_test_warehouse"
TestWarehouseName2 = "terraform_test_warehouse_2"
TestUserName = "terraform_test_user"
)

var (
Expand Down Expand Up @@ -120,6 +121,13 @@ func TestAccPreCheck(t *testing.T) {
}); err != nil {
t.Fatal(err)
}

userId := sdk.NewAccountObjectIdentifier(TestUserName)
if err := atc.client.Users.Create(ctx, userId, &sdk.CreateUserOptions{
IfNotExists: sdk.Bool(true),
}); err != nil {
t.Fatal(err)
}
})
}

Expand Down
35 changes: 35 additions & 0 deletions pkg/resources/object_parameter_acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,27 @@ func TestAcc_ObjectParameterAccount(t *testing.T) {
})
}

func TestAcc_UserParameter(t *testing.T) {
resource.Test(t, resource.TestCase{
ProtoV6ProviderFactories: acc.TestAccProtoV6ProviderFactories,
TerraformVersionChecks: []tfversion.TerraformVersionCheck{
tfversion.RequireAbove(tfversion.Version1_5_0),
},
PreCheck: func() { acc.TestAccPreCheck(t) },
CheckDestroy: nil,
Steps: []resource.TestStep{
{
Config: userParameterConfigBasic("ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR", "true", acc.TestUserName),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("snowflake_object_parameter.p", "key", "ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR"),
resource.TestCheckResourceAttr("snowflake_object_parameter.p", "value", "true"),
resource.TestCheckResourceAttr("snowflake_object_parameter.p", "on_account", "false"),
),
},
},
})
}

func objectParameterConfigOnAccount(key, value string) string {
s := `
resource "snowflake_object_parameter" "p" {
Expand All @@ -76,3 +97,17 @@ resource "snowflake_object_parameter" "p" {
`
return fmt.Sprintf(s, key, value, databaseName)
}

func userParameterConfigBasic(key, value, username string) string {
s := `
resource "snowflake_object_parameter" "p" {
key = "%s"
value = "%s"
object_type = "USER"
object_identifier {
name = "%s"
}
}
`
return fmt.Sprintf(s, key, value, username)
}
2 changes: 2 additions & 0 deletions pkg/sdk/parameters.go
Original file line number Diff line number Diff line change
Expand Up @@ -1004,6 +1004,8 @@ func (v *parameters) ShowObjectParameter(ctx context.Context, parameter ObjectPa
opts.In.Task = object.Name.(SchemaObjectIdentifier)
case ObjectTypeTable:
opts.In.Table = object.Name.(SchemaObjectIdentifier)
case ObjectTypeUser:
opts.In.User = object.Name.(AccountObjectIdentifier)
default:
return nil, fmt.Errorf("unsupported object type %s", object.Name)
}
Expand Down

0 comments on commit 57c6953

Please sign in to comment.