-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate streams to the new sdk #2113
Conversation
Integration tests failure for 21f84c8c36b7f40eddf393c798bfce233e4e6f30 |
b0a7c78
to
ff43c83
Compare
Integration tests failure for b0a7c7801f5eda34eb8e82a5ea984a9da64530e7 |
Integration tests failure for ff43c834d72b1c10cfdd28edefc0c9e3b721de9c |
ff43c83
to
18bd851
Compare
18bd851
to
5969b8e
Compare
5969b8e
to
377a843
Compare
Integration tests failure for 18bd8513c032d99b93a7c1efa52cb65cb3f638f0 |
Integration tests failure for 5969b8eedd91d65eaafd331ed8a6767cc9d778b1 |
Integration tests failure for 377a843714009045ccfa9a848bccd9668156dd35 |
pkg/sdk/streams_dto_builders_gen.go
Outdated
|
||
package sdk | ||
|
||
import () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty import block? hmm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the generator artifact and the whole code here is generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty import won't do anything and we've marked this file as generated (with standard comment that is recognisable by IDEs and linters - otherwise some linter would create a comment that it's not "fumpted") and that it shouldn't be changed, so I think we can leave it as is ?
pkg/sdk/streams_dto_builders_gen.go
Outdated
return s | ||
} | ||
|
||
func NewCreateOnStageStreamRequest( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be directory table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment in doc states it's a directory, but the syntax has on stage. I'm fine with both, @sfc-gh-jcieslak it's your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it to be consistent with the documentation
pkg/sdk/streams_dto_builders_gen.go
Outdated
|
||
package sdk | ||
|
||
import () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the generator artifact and the whole code here is generated
pkg/sdk/streams_dto_builders_gen.go
Outdated
return s | ||
} | ||
|
||
func NewCreateOnStageStreamRequest( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment in doc states it's a directory, but the syntax has on stage. I'm fine with both, @sfc-gh-jcieslak it's your call.
Integration tests failure for babf385a17b93f2397ca9f473f77c9a2fe281929 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
golangci
pkg/sdk/streams_validations_gen.go|50 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|52 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|52 col 6| too many errors) (typecheck)
pkg/sdk/streams_impl_gen.go|65 col 9| undefined: findOne
pkg/sdk/streams_validations_gen.go|19 col 22| undefined: errNilOptions
pkg/sdk/streams_validations_gen.go|22 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|23 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|25 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|26 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|46 col 22| undefined: errNilOptions
pkg/sdk/streams_validations_gen.go|49 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|50 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|52 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|52 col 6| too many errors (typecheck)
pkg/sdk/streams_impl_gen.go|65 col 9| undefined: findOne
pkg/sdk/streams_validations_gen.go|19 col 22| undefined: errNilOptions
pkg/sdk/streams_validations_gen.go|22 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|23 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|25 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|26 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|46 col 22| undefined: errNilOptions
pkg/sdk/streams_validations_gen.go|49 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|50 col 23| undefined: errInvalidObjectIdentifier
pkg/sdk/streams_validations_gen.go|52 col 6| undefined: validObjectidentifier
pkg/sdk/streams_validations_gen.go|52 col 6| too many errors) (typecheck)
pkg/sdk/testint/streams_gen_integration_test.go|40 col 61| undefined: randomAlphanumericN (typecheck)
pkg/sdk/testint/streams_gen_integration_test.go|61 col 74| undefined: randomAlphanumericN (typecheck)
pkg/sdk/testint/streams_gen_integration_test.go|69 col 61| undefined: randomAlphanumericN (typecheck)
babf385
to
ce2f648
Compare
Integration tests failure for ce2f6483eec5361e20e3e00d2e59a0439dccac9b |
ce2f648
to
ba1f3fe
Compare
Integration tests success for ba1f3fe992909d49953a7f0e9c6e0a8349b3b838 |
ba1f3fe
to
752aa9e
Compare
Integration tests success for 752aa9e3ecb841118c6754089838ca4db5f32e34 |
Integration tests failure for 752aa9e3ecb841118c6754089838ca4db5f32e34 |
175bdc6
752aa9e
to
175bdc6
Compare
Integration tests failure for 175bdc6079bab65d17b13367cbe4d4fa9e0d0c65 |
Integration tests success for 175bdc6079bab65d17b13367cbe4d4fa9e0d0c65 |
Test Plan
References