fix: Fix encode Snowflake ID for object identifiers #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Integration tests failure for 52b0695c77b51cee0e49bc0416c556daed3c000b |
|
Integration tests failure for 74865a311be8572a8481e6bac277d4a19d51dc6a |
sfc-gh-asawicki
force-pushed
the
fix-encoide-snowflake-id-for-object-identifiers
branch
from
74865a3
to
db006f6
Compare
|
Integration tests failure for db006f6429c9568a434a8e39d9d8271748152d59 |
sfc-gh-jcieslak
previously approved these changes
Dec 12, 2023
|
Integration tests failure for ad98c8d2a2f0720bc30d749b8638830eeaf4b092 |
sfc-gh-jcieslak
approved these changes
Dec 12, 2023
sfc-gh-asawicki
deleted the
fix-encoide-snowflake-id-for-object-identifiers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix encoding SnowflakeIDs for SDK object identifiers.
It still needs work for other types; we will revisit this with identifiers rework.
Fix #2058