Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce shared function to suspend task roots #2650

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Refactor previously planned function for task suspension, which is also necessary to push the grant ownership resource forward.

Test Plan

  • acceptance tests - tested on exiting tests (had to adjust new suspension code to mimic what was previously, otherwise I got a Snowflake error indicating that the root tasks were not suspended and the logic was wrong).
  • integration test to test new SDK function

Reference

CREATE TASK

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review March 25, 2024 15:34
Copy link

Integration tests failure for fd4aa5f24849036150bb558b768919aa2f3499a0

Copy link

Integration tests failure for 214f86e1254494e03230505962610e628a11214e

Copy link

Integration tests failure for 17fa000b2d3c4c4bb2238d3e6fa6649d5294078a

Copy link

Integration tests failure for b520be8171314680f447fc524d36fba2aef8f8b4

Copy link

Integration tests failure for 214f86e1254494e03230505962610e628a11214e

pkg/resources/task.go Outdated Show resolved Hide resolved
pkg/resources/task.go Outdated Show resolved Hide resolved
pkg/sdk/tasks_gen.go Outdated Show resolved Hide resolved
pkg/sdk/tasks_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/testint/tasks_gen_integration_test.go Show resolved Hide resolved
pkg/resources/task.go Show resolved Hide resolved
Copy link

Integration tests failure for 501fe1f0d22b8d715944467197d222201ad59be6

Copy link

Integration tests failure for 79443c162860bd3e9f4be68bc79b16634ab68a81

Copy link

Integration tests failure for 4495b27a0232452b34b9a3790f868cc0c3e8eaf4

Copy link

Integration tests failure for 0b42d23d6e84e59778b4ef5e613a02b05f00b0ed

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit d684b5d into main Apr 3, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the refactor-task-suspension-logic branch April 3, 2024 09:56
sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.88.0](v0.87.3-pre...v0.88.0)
(2024-04-09)


### 🎉 **What's new:**

* Fix issues 2651 2656
([#2659](#2659))
([7fa09cc](7fa09cc))
* Grant ownership follow up
([#2628](#2628))
([d467e5b](d467e5b))
* grant ownership follow-up
([#2658](#2658))
([bfa2317](bfa2317))
* grant ownership on tasks
([#2684](#2684))
([2ba7889](2ba7889))
* Introduce shared function to suspend task roots
([#2650](#2650))
([d684b5d](d684b5d))
* Redesign snowflake_grants datasource
([#2667](#2667))
([918873d](918873d))
* user password policy attachment
([#2627](#2627))
([382e49d](382e49d))


### 🔧 **Misc**

* release 0.88.0
([02d60e0](02d60e0))
* Update grant examples in all resources
([#2660](#2660))
([b542b69](b542b69))


### 🐛 **Bug fixes:**

* Adjust dynamic tables after BCR-1543
([#2664](#2664))
([cf32ceb](cf32ceb))
* Fix handling secure views read and import
([#2655](#2655))
([3c3ede6](3c3ede6))
* Fix issues 2606 2642 2652 2653
([#2654](#2654))
([4a73721](4a73721))
* Fix release workflow
([#2639](#2639))
([dfd07e9](dfd07e9))
* Generate docs for dynamic table
([#2666](#2666))
([16c75b0](16c75b0))
* grant read operation
([#2665](#2665))
([0b947a5](0b947a5))
* migration guide for databases created from share
([#2637](#2637))
([f9651bc](f9651bc))
* with_grant_option diff drift
([#2608](#2608))
([f0018c6](f0018c6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants