feat: add snowflake_grant_application_role resource #2690

sfc-gh-swinkler · 2024-04-10T00:17:26Z

Adds a new resource for grant_application_role. Also adds some stuff to SDK to make it work. Relies on an app package to exist, which may not exist in the current account. No application resource currently exists to use.

Test Plan

acceptance tests

…

References

https://docs.snowflake.com/en/sql-reference/sql/grant-application-role

github-actions · 2024-04-10T01:11:57Z

Integration tests failure for e778c23b596b62218059350b8ad0a0316703990d

pkg/resources/grant_application_role_acceptance_test.go

pkg/sdk/testint/application_roles_gen_integration_test.go

pkg/resources/grant_application_role.go

pkg/resources/grant_application_role_acceptance_test.go

github-actions · 2024-04-12T00:44:55Z

Integration tests failure for b5d4406699857e1f6ad94570c1ccdf5a086ef1ef

github-actions · 2024-04-13T01:24:14Z

Integration tests failure for 1b44738ff10350badc5420afd2fca2dad7a059be

github-actions · 2024-04-13T01:57:16Z

Integration tests failure for f3f9cb6619921bc7e71fa12d318da1169a2a6347

github-actions · 2024-04-13T01:59:08Z

Integration tests failure for 06e559994d5a7155916bf48c61180218e31666a0

pkg/resources/grant_application_role.go

github-actions · 2024-04-17T00:56:17Z

Integration tests failure for 40fb6437dad55ad95ad1beff4441b0639990b334

github-actions · 2024-04-18T04:45:00Z

Integration tests failure for ebcce67df826ca9a0030e049d8078822b5834f9f

gitguardian · 2024-04-22T16:45:27Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9467623	Triggered	Generic Password	`76365d5`	pkg/resources/password_policy_acceptance_test.go	View secret
9467623	Triggered	Generic Password	`76365d5`	pkg/resources/password_policy_acceptance_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

github-actions · 2024-04-22T16:47:40Z

Integration tests failure for 76365d5ed8d5f45ef6ed25db54b7e87b51f43ee7

github-actions · 2024-05-08T09:07:03Z

Integration tests failure for db8d665d7fe8cdb1ef9811ae4365a4db5c7acb7a

github-actions · 2024-05-08T09:36:02Z

Integration tests failure for 93a1e2f7e091adeb343b5b55020606f73e66cb79

github-actions · 2024-05-08T14:07:43Z

Integration tests failure for 94833d75ad0eedfb907d4559075744c071b93f2e

pkg/resources/grant_application_role.go

pkg/resources/testdata/TestAcc_GrantApplicationRole/application/test.tf

github-actions · 2024-05-09T07:48:52Z

Integration tests failure for 5dc9593e9df80c2bd9ee3159e7ce32b9d9ced828

github-actions · 2024-05-09T07:51:44Z

Integration tests failure for 2956f7902d7b296f3aaf71b586dbf096701b9d58

github-actions · 2024-05-09T08:51:01Z

Integration tests failure for 739686a5279b5475c580129542ad2fe32f4199ca

v1-preparations/REMAINING_GA_OBJECTS.MD

pkg/sdk/testint/application_roles_gen_integration_test.go

pkg/sdk/config.go

pkg/resources/testdata/TestAcc_GrantApplicationRole/account_role/variables.tf

pkg/resources/grant_application_role_acceptance_test.go

pkg/resources/testdata/TestAcc_GrantApplicationRole/application/manifest.yml

pkg/resources/testdata/TestAcc_GrantApplicationRole/application/test.tf

github-actions · 2024-05-15T10:57:06Z

Integration tests failure for 86bb80a879d3b189d8401bde9e6a5d1cc0508b07

pkg/resources/grant_application_role_acceptance_test.go

pkg/acceptance/helpers/application_client.go

github-actions · 2024-05-16T07:59:59Z

Integration tests failure for 6321eee8a0de365bce34c328d852eb94984e6b69

github-actions · 2024-05-16T08:52:16Z

Integration tests success for 6321eee8a0de365bce34c328d852eb94984e6b69

🤖 I have created a release *beep* *boop* --- ## [0.91.0](v0.90.0...v0.91.0) (2024-05-16) ### 🎉 **What's new:** * add snowflake_grant_application_role resource ([#2690](#2690)) ([838d241](838d241)) * datasource database role ([#2731](#2731)) ([319ddc3](319ddc3)) ### 🔧 **Misc** * Add few documentation adjustments ([#2789](#2789)) ([6db8bf3](6db8bf3)) * Bump dependencies ([#2802](#2802)) ([54ea6bc](54ea6bc)) * Replace parsing function for saving granted object names ([#2813](#2813)) ([175cfc7](175cfc7)) ### 🐛 **Bug fixes:** * Fix sweepers ([#2800](#2800)) ([a01115e](a01115e)) * Invoke SetId immediately after alert creation ([#2786](#2786)) ([181b4d0](181b4d0)) * Update the tests after snowflake bugfix ([#2806](#2806)) ([6843c1a](6843c1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

add application role

e778c23

sfc-gh-asawicki requested review from sfc-gh-asawicki and sfc-gh-jcieslak and removed request for sfc-gh-asawicki April 10, 2024 10:03

sfc-gh-asawicki requested changes Apr 10, 2024

View reviewed changes

pkg/resources/grant_application_role_acceptance_test.go Show resolved Hide resolved

pkg/resources/grant_application_role_acceptance_test.go Outdated Show resolved Hide resolved

pkg/sdk/testint/application_roles_gen_integration_test.go Show resolved Hide resolved

sfc-gh-jcieslak requested changes Apr 10, 2024

View reviewed changes

create app using tf

b5d4406

sfc-gh-swinkler added 2 commits April 12, 2024 18:03

fix tests

f3f9cb6

Merge branch 'main' into grant-app-role

1b44738

randomize name

06e5599

sfc-gh-jcieslak reviewed Apr 16, 2024

View reviewed changes

pkg/resources/grant_application_role.go Show resolved Hide resolved

pkg/resources/grant_application_role.go Outdated Show resolved Hide resolved

sfc-gh-swinkler added 2 commits April 16, 2024 16:43

fix id

a8e5f6f

Merge branch 'main' into grant-app-role

40fb643

Merge branch 'main' into grant-app-role

ebcce67

Merge branch 'main' into grant-app-role

76365d5

sfc-gh-jmichalak added 2 commits May 8, 2024 10:25

Fix linter issues and tests

824b56c

Merge remote-tracking branch 'origin/main' into grant-app-role

db8d665

Restore manifest2

93a1e2f

sfc-gh-jcieslak requested changes May 9, 2024

View reviewed changes

pkg/resources/grant_application_role.go Outdated Show resolved Hide resolved

pkg/resources/testdata/TestAcc_GrantApplicationRole/application/test.tf Outdated Show resolved Hide resolved

Remove custom provider

5dc9593

sfc-gh-jmichalak force-pushed the grant-app-role branch from 2956f79 to 5dc9593 Compare May 9, 2024 06:53

Test app creation order

739686a

sfc-gh-jcieslak previously approved these changes May 9, 2024

View reviewed changes

sfc-gh-asawicki self-requested a review May 14, 2024 11:38

sfc-gh-asawicki requested changes May 14, 2024

View reviewed changes

sfc-gh-jmichalak added 4 commits May 15, 2024 10:04

Merge remote-tracking branch 'origin/main' into grant-app-role

8a58368

Fixes

7cbd64d

Improve acc tests

bc8cf63

Merge remote-tracking branch 'origin/main' into grant-app-role

86bb80a

sfc-gh-jmichalak dismissed sfc-gh-jcieslak’s stale review via 86bb80a May 15, 2024 10:00

sfc-gh-asawicki self-requested a review May 15, 2024 12:32

sfc-gh-asawicki requested changes May 15, 2024

View reviewed changes

pkg/resources/grant_application_role_acceptance_test.go Outdated Show resolved Hide resolved

pkg/resources/grant_application_role_acceptance_test.go Outdated Show resolved Hide resolved

pkg/acceptance/helpers/application_client.go Outdated Show resolved Hide resolved

sfc-gh-jmichalak added 2 commits May 16, 2024 09:44

Fixes

a978053

Merge remote-tracking branch 'origin/main' into grant-app-role

6321eee

sfc-gh-asawicki self-requested a review May 16, 2024 08:44

sfc-gh-asawicki approved these changes May 16, 2024

View reviewed changes

sfc-gh-jcieslak approved these changes May 16, 2024

View reviewed changes

sfc-gh-jmichalak merged commit 838d241 into main May 16, 2024
10 checks passed

sfc-gh-jmichalak deleted the grant-app-role branch May 16, 2024 10:13

snowflake-release-please bot mentioned this pull request May 16, 2024

chore(main): release 0.91.0 #2791

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add snowflake_grant_application_role resource #2690

feat: add snowflake_grant_application_role resource #2690

sfc-gh-swinkler commented Apr 10, 2024 •

edited by sfc-gh-jmichalak

Loading

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented Apr 13, 2024

github-actions bot commented Apr 13, 2024

github-actions bot commented Apr 13, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 18, 2024

gitguardian bot commented Apr 22, 2024 •

edited

Loading

github-actions bot commented Apr 22, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 15, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

feat: add snowflake_grant_application_role resource #2690

feat: add snowflake_grant_application_role resource #2690

Conversation

sfc-gh-swinkler commented Apr 10, 2024 • edited by sfc-gh-jmichalak Loading

Test Plan

References

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented Apr 13, 2024

github-actions bot commented Apr 13, 2024

github-actions bot commented Apr 13, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 18, 2024

gitguardian bot commented Apr 22, 2024 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

github-actions bot commented Apr 22, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 15, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

sfc-gh-swinkler commented Apr 10, 2024 •

edited by sfc-gh-jmichalak

Loading

gitguardian bot commented Apr 22, 2024 •

edited

Loading