Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add network rules #2746

Merged
merged 19 commits into from
May 23, 2024
Merged

feat: add network rules #2746

merged 19 commits into from
May 23, 2024

Conversation

Relativity74205
Copy link
Contributor

@Relativity74205 Relativity74205 commented Apr 25, 2024 •
edited
Loading

resolves #2482

  • adds network rules
  • adds network rule lists to network policies
  • fixes network policies

Test Plan

  • acceptance tests
  • …

References

@Relativity74205 Relativity74205 changed the title Add network rules WIP: Add network rules Apr 25, 2024
@Relativity74205 Relativity74205 mentioned this pull request Apr 25, 2024
Closed
@Relativity74205 Relativity74205 changed the title WIP: Add network rules Add network rules May 15, 2024
@Relativity74205 Relativity74205 changed the title Add network rules feat: add network rules May 15, 2024
sfc-gh-jmichalak
sfc-gh-jmichalak requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good :) Please also add import.sh and resource.tf to examples/resources/snowflake_network_role and regenerate docs

pkg/resources/network_policy_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/network_policy.go Outdated Show resolved Hide resolved
sfc-gh-jcieslak
sfc-gh-jcieslak reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 I had a few small comments, but other than that very good pr 👍

pkg/resources/network_rule.go Outdated Show resolved Hide resolved
pkg/resources/network_rule.go Outdated Show resolved Hide resolved
examples/resources/snowflake_network_rule/import.sh Outdated Show resolved Hide resolved
pkg/resources/network_policy_acceptance_test.go Show resolved Hide resolved
@sfc-gh-asawicki
Copy link
Collaborator

Hey @Relativity74205. Thanks for your contribution!

I would also like to review it. I am just letting you know, that I will be able to check it on Monday at the earliest. Sorry, for the delay!

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review May 20, 2024 09:10
sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes May 20, 2024
View reviewed changes
docs/resources/network_policy.md Show resolved Hide resolved
pkg/resources/network_policy.go Outdated Show resolved Hide resolved
@Relativity74205
Copy link
Contributor Author

@sfc-gh-asawicki @sfc-gh-jcieslak @sfc-gh-jmichalak
I think I have covered all yours comments. Is there anything else? If not, I would appreciate it, if we could finally merge this one :)

@sfc-gh-asawicki
Copy link
Collaborator

/ok-to-test sha=38f2184be4a262d6d6ecd0167a8f8aa86e5ff5fa

@github-actions GitHub Actions
Copy link

Integration tests success for 38f2184be4a262d6d6ecd0167a8f8aa86e5ff5fa

@sfc-gh-asawicki sfc-gh-asawicki merged commit c79fa29 into Snowflake-Labs:main May 23, 2024
8 checks passed
@sfc-gh-asawicki
Copy link
Collaborator

Merged! Thanks for your contribution @Relativity74205!

@snowflake-release-please snowflake-release-please bot mentioned this pull request May 23, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Jun 6, 2024
@snowflake-release-please
chore(main): release 0.92.0 (#2824)
5df6d3d 
🤖 I have created a release *beep* *boop*
---


##
[0.92.0](v0.91.0...v0.92.0)
(2024-06-06)


### 🎉 **What's new:**

* Add Api Authentication security integration to sdk
([#2840](#2840))
([57a07ee](57a07ee))
* Add External Oauth security integration to sdk
([#2835](#2835))
([82d1c09](82d1c09))
* add network rules
([#2746](#2746))
([c79fa29](c79fa29))
* Add SCIM and SAML2 security integrations to sdk
([#2799](#2799))
([1312ff1](1312ff1))
* Add Snowflake Oauth security integration to sdk
([#2830](#2830))
([b576f29](b576f29))
* Database resource v1 readiness
([#2834](#2834))
([30fe136](30fe136))
* Database SDK upgrade
([#2814](#2814))
([750fe37](750fe37))


### 🔧 **Misc**

* accept non-pointer values in the generated builder methods
([#2816](#2816))
([c29fbf1](c29fbf1))
* Add a script for creating labels
([#2778](#2778))
([ce0fbad](ce0fbad))
* Adjust before 0.92.0
([#2857](#2857))
([0598656](0598656))
* Continue random ids rework
([#2819](#2819))
([f20940c](f20940c))
* Random ids rework part3
([#2833](#2833))
([36ead85](36ead85))
* Random ids rework part4
([#2837](#2837))
([64518a3](64518a3))
* Update issue for table and warehouse redesign state
([#2845](#2845))
([149e55e](149e55e))


### 🐛 **Bug fixes:**

* Fix failing integration tests
([#2832](#2832))
([2e2ca6c](2e2ca6c))
* Fix QUOTED_IDENTIFIERS_IGNORE_CASE parameter test
([#2841](#2841))
([92ad1d3](92ad1d3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for network rules
5 participants
@Relativity74205 @sfc-gh-asawicki @sfc-gh-jcieslak @sfc-gh-jmichalak @AS-auxmoney