-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update failover group allowed integration types #2776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing types in SDK - Update resource docs - Update tests
sfc-gh-jmichalak
changed the title
Update failover group allowed integration types
fix: Update failover group allowed integration types
May 6, 2024
Integration tests failure for c024978513569221208d6e5133676e744c72f6c4 |
Integration tests failure for 6b3b1853a4b0c1a179a5b78c6895ea84af843875 |
sfc-gh-asawicki
approved these changes
May 7, 2024
@@ -423,7 +425,7 @@ func (row failoverGroupDBRow) convert() *FailoverGroup { | |||
if it == "" { | |||
continue | |||
} | |||
allowedIntegrationTypes = append(allowedIntegrationTypes, IntegrationType(strings.TrimSpace(it)+" INTEGRATIONS")) | |||
allowedIntegrationTypes = append(allowedIntegrationTypes, IntegrationType(strings.ReplaceAll(strings.TrimSpace(it), "_", " ")+" INTEGRATIONS")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bleh. But we will redo it with failover groups rework, fine for now
sfc-gh-jcieslak
approved these changes
May 7, 2024
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
May 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.90.0](v0.89.0...v0.90.0) (2024-05-08) ### 🎉 **What's new:** * Adjust owner_role_type and schema_evolution_record columns ([#2740](#2740)) ([424e393](424e393)) ### 🔧 **Misc** * Add a guide on creating issues ([#2758](#2758)) ([2b006aa](2b006aa)) * Add missing documentation ([#2781](#2781)) ([cc0a6a7](cc0a6a7)) * Add scripts to close issues from Pre Snowflake bucket ([#2762](#2762)) ([44c0c37](44c0c37)) * Add small adjustments ([#2783](#2783)) ([e5b0b4b](e5b0b4b)) * Adjust issue templates ([#2748](#2748)) ([64ab76d](64ab76d)) * Cleanup helpers part 3 ([#2730](#2730)) ([eb7bee4](eb7bee4)) * Cleanup helpers part 5 ([#2744](#2744)) ([1f165bf](1f165bf)) * Cleanup helpers part4 ([#2741](#2741)) ([9475e35](9475e35)) * Cleanup helpers part6 ([#2745](#2745)) ([eba3029](eba3029)) * Cleanup helpers poc ([#2724](#2724)) ([70b99fb](70b99fb)) * Helpers cleanup continuation ([#2726](#2726)) ([a70d1af](a70d1af)) * Prepare new roadmap entry ([#2773](#2773)) ([b0bf28f](b0bf28f)) * Prepare parallel builds ([#2737](#2737)) ([6974e25](6974e25)) * Update the contribution guidelines (and small fixes) ([#2753](#2753)) ([aafdc72](aafdc72)) ### 🐛 **Bug fixes:** * Fix issue templates ([#2760](#2760)) ([d0d5048](d0d5048)) * Fix setup for two tests ([#2757](#2757)) ([df025b0](df025b0)) * Fix Test (wrong order of arguments) ([#2780](#2780)) ([02f467e](02f467e)) * Fix/prove issues [#2733](#2733) [#2735](#2735) [#2763](#2763) [#2767](#2767) ([#2777](#2777)) ([7b1c67e](7b1c67e)) * Prove problems with procedure resource data types ([#2782](#2782)) ([68d0318](68d0318)) * read after create ([#2718](#2718)) ([2e9b68f](2e9b68f)) * UNSET and empty SET in network policies ([#2759](#2759)) ([3eacb0b](3eacb0b)) * unset network policy should not have single quotes ([#2584](#2584)) ([8f2a363](8f2a363)) * Update failover group allowed integration types ([#2776](#2776)) ([efde48d](efde48d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References
https://docs.snowflake.com/en/sql-reference/sql/create-failover-group
Based on #2518