fix: Invoke SetId immediately after alert creation #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, after failing alert alter operation, terraform keeps the created alert in state. Alert can be now modified by using terraform apply. Also, CRUD functions are changed to functions with context due to deprecations in terraform sdk.
|
Integration tests failure for b531b45b664ea53fc4ffec8206a09f0dc3b2da96 |
sfc-gh-jcieslak
approved these changes
May 10, 2024
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.91.0](v0.90.0...v0.91.0) (2024-05-16) ### 🎉 **What's new:** * add snowflake_grant_application_role resource ([#2690](#2690)) ([838d241](838d241)) * datasource database role ([#2731](#2731)) ([319ddc3](319ddc3)) ### 🔧 **Misc** * Add few documentation adjustments ([#2789](#2789)) ([6db8bf3](6db8bf3)) * Bump dependencies ([#2802](#2802)) ([54ea6bc](54ea6bc)) * Replace parsing function for saving granted object names ([#2813](#2813)) ([175cfc7](175cfc7)) ### 🐛 **Bug fixes:** * Fix sweepers ([#2800](#2800)) ([a01115e](a01115e)) * Invoke SetId immediately after alert creation ([#2786](#2786)) ([181b4d0](181b4d0)) * Update the tests after snowflake bugfix ([#2806](#2806)) ([6843c1a](6843c1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, after failing alert alter operation, terraform keeps the created alert in state. A warning is shown to a user when alter fails. Alert can be now enabled by using terraform apply.
Also, CRUD functions are changed to functions with context due to deprecations in terraform sdk.
This change was tested on a real Snowflake environment.
Test Plan
References