Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Role v1 readiness #2916

Merged
merged 9 commits into from
Jul 12, 2024
Merged

feat: Role v1 readiness #2916

merged 9 commits into from
Jul 12, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Jul 9, 2024

Changes:

  • resource added/adjusted
    • added account_role resource (the old one shares the same implementation as the new one, but it has the deprecation message) to fit with other resources that work with roles (mostly grants)
    • added show output attribute
  • data source adjusted
    • structure and attribute names adjusted to the conventions
  • documentation
    • Entries added to the migration guide
    • Examples adjusted (adjusted the old role documentation and replaced deprecated role resource with the new one in the examples for other resources)
    • Added V1 release candidate note

Test Plan

  • acceptance tests adjusted to the standard ones

References

@sfc-gh-jcieslak sfc-gh-jcieslak changed the title chore: Role v1 readiness feat: Role v1 readiness Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Integration tests failure for e1860a10ab8f374c26ea5476f685f64dec1e00d3

Copy link

github-actions bot commented Jul 9, 2024

Integration tests failure for e6aff1deb47942068beb78cf580cc82d8c3b1d15

Copy link

Integration tests failure for d6dac25ef2e9b75ae4147eb23f44d5a2d61a6f9a

Copy link

Integration tests failure for bf99277169dfbfc820a2811e2287a1c90c16fed8

Copy link

Integration tests failure for 7d636f10190128edc673b4f872b669ad0f16df01

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review July 10, 2024 13:47
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
docs/data-sources/roles.md Show resolved Hide resolved
pkg/resources/account_role.go Show resolved Hide resolved
# Conflicts:
#	pkg/provider/resources/resources.go
#	pkg/resources/testdata/TestAcc_GrantPrivilegesToRole/ImportedPrivileges/test.tf
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review July 12, 2024 07:59
Copy link

Integration tests failure for 5b41cdf84a80b3d0e9b55cc76e3cb3e2758861e2

Copy link

Integration tests failure for 05ee620c82c6decbdb74e94215cbe81a041bfc63

Copy link

Integration tests cancelled for 680a7b7705a4f2ed6f9796251bcfec9c5e246b02

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 32c7690 into main Jul 12, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the role-v1-readiness branch July 12, 2024 13:31
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.94.0](v0.93.0...v0.94.0)
(2024-07-26)


### 🎉 **What's new:**

* Add missing session parameters
([#2936](#2936))
([4ce662d](4ce662d))
* Adjust user SDK
([#2947](#2947))
([1127bb3](1127bb3))
* Better tests poc
([#2917](#2917))
([ef496c2](ef496c2))
* Introduce assertions generators part1
([#2952](#2952))
([1582a9f](1582a9f))
* Introduce assertions generators part2
([#2956](#2956))
([f715e8a](f715e8a))
* network policy v1 readiness
([#2914](#2914))
([3408c3f](3408c3f))
* Rework schema datasource
([#2954](#2954))
([f70e40e](f70e40e))
* Rework schema resource
([#2955](#2955))
([400a5c8](400a5c8))
* Role v1 readiness
([#2916](#2916))
([32c7690](32c7690))
* Schema SDK upgrade
([#2945](#2945))
([bca0836](bca0836))
* Streamlit v1 readiness
([#2930](#2930))
([aa42260](aa42260))


### 🔧 **Misc**

* Remove deprecation from unsafe execute
([#2941](#2941))
([ed712d7](ed712d7))
* Update documentation
([#2931](#2931))
([da98bc3](da98bc3))


### 🐛 **Bug fixes:**

* ATTRIBUTE set(string) parsing for cortex search service
([#2953](#2953))
([70a1c9a](70a1c9a))
* external function header parsing and add missing privileges
([#2961](#2961))
([9d882fe](9d882fe))
* Fix sync_password field for Azure scim clients
([#2950](#2950))
([6781133](6781133))
* Fix tests and relax warehouse validations
([#2959](#2959))
([dd01ce9](dd01ce9)),
closes
[#2948](#2948)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants