Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: fail to create snowflake_account_parameter #3025

Open
1 task
bob-zarkoob opened this issue Aug 29, 2024 · 8 comments
Open
1 task

[Bug]: fail to create snowflake_account_parameter #3025

bob-zarkoob opened this issue Aug 29, 2024 · 8 comments
Assignees
Labels
bug Used to mark issues with provider's incorrect behavior

Comments

@bob-zarkoob
Copy link

bob-zarkoob commented Aug 29, 2024

Terraform CLI Version

1.9.5

Terraform Provider Version

0.94.1

Terraform Configuration

resource "snowflake_account_parameter" "p7" {
  key   = "OAUTH_ADD_PRIVILEGED_ROLES_TO_BLOCKED_LIST"
  value = true
}

Category

category:resource

Object type(s)

resource:account_parameter

Expected Behavior

to create the resource

Actual Behavior

Error: Invalid object parameter: OAUTH_ADD_PRIVILEGED_ROLES_TO_BLOCKED_LIST
with module.snowflake_params.snowflake_account_parameter.p7
on account-parameters/main.tf line 45, in resource "snowflake_account_parameter" "p7":
resource "snowflake_account_parameter" "p7" {

While this parameter is in the list of acceptable parameters.

Steps to Reproduce

  1. copy config
  2. run terraform apply

How much impact is this issue causing?

Medium

Logs

No response

Additional Information

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@bob-zarkoob bob-zarkoob added the bug Used to mark issues with provider's incorrect behavior label Aug 29, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @bob-zarkoob 👋
It seems like we have missing mapping for this one. I'll take care of it. Please use unsafe_execute for now.

@sfc-gh-jcieslak sfc-gh-jcieslak self-assigned this Aug 30, 2024
sfc-gh-jcieslak added a commit that referenced this issue Sep 3, 2024
## Addressed issues
* #3016 `SHOW ORGANIZATION ACCOUNTS` -> `SHOW ACCOUNTS` BCR
* #3015
* #2807
* #3025
sfc-gh-jcieslak pushed a commit that referenced this issue Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.95.0](v0.94.1...v0.95.0)
(2024-09-04)


### 🎉 **What's new:**

* Add change_tracking, row access policy and aggregation policy to views
([#2988](#2988))
([1f88bb1](1f88bb1))
* Add fully_qualified_name to all resources
([#2990](#2990))
([1b0462f](1b0462f))
* Add identifier parsers
([#2957](#2957))
([824ec52](824ec52))
* Add identifier with arguments
([#2979](#2979))
([00ae1c5](00ae1c5))
* Add timeouts block to cortex
([#3004](#3004))
([34d764b](34d764b))
* Add user parameters to resource
([#2968](#2968))
([f4ae380](f4ae380))
* Conclude user rework
([#3036](#3036))
([23e4625](23e4625))
* database role v1 readiness
([#3014](#3014))
([c4db255](c4db255))
* Identifier with arguments for procedure and external function
([#2987](#2987))
([f13cc5c](f13cc5c))
* Rework user resource
([#3026](#3026))
([bde2638](bde2638)),
closes
[#1572](#1572)
* Rework users datasource
([#3030](#3030))
([751239b](751239b)),
closes
[#2902](#2902)
* Upgrade view sdk
([#2969](#2969))
([ef2d50a](ef2d50a))
* View rework part 2
([#3021](#3021))
([e05377d](e05377d))
* View rework part 3
([#3023](#3023))
([195b41c](195b41c))


### 🔧 **Misc**

* Add annotation about fully_qualified_name and fix handling granteeName
([#3009](#3009))
([94e6345](94e6345))
* Apply identifier conventions
([#2996](#2996))
([5cbea84](5cbea84))
* apply identifier conventions to grants
([#3008](#3008))
([d7780ae](d7780ae))
* Clean collection utils
([#3028](#3028))
([426ddb1](426ddb1))
* Clean old assertions
([#3029](#3029))
([ad657eb](ad657eb))
* Conclude identifiers rework
([#3011](#3011))
([c1b53f3](c1b53f3))
* Improve user test and add manual test for user default database and
role
([#3035](#3035))
([6cb0b4e](6cb0b4e))
* Use new identifier with arguments in function, external function and
procedure grants
([#3002](#3002))
([5053f8b](5053f8b))
* User improvements
([#3034](#3034))
([65b64d7](65b64d7))


### 🐛 **Bug fixes:**

* database tests and introduce a new parameter
([#2981](#2981))
([3bae7f6](3bae7f6))
* Fix custom diffs for fields with diff supression
([#3032](#3032))
([2499602](2499602))
* Fix default secondary roles after BCR 2024_07
([#3040](#3040))
([2ca465a](2ca465a)),
closes
[#3038](#3038)
* Fix issues 2972 and 3007
([#3020](#3020))
([1772387](1772387))
* Fix known user resource issues
([#3013](#3013))
([a5dfeac](a5dfeac))
* identifier issues
([#2998](#2998))
([6fb76b7](6fb76b7))
* minor issues
([#3027](#3027))
([467b06e](467b06e)),
closes
[#3015](#3015)
[#2807](#2807)
[#3025](#3025)
* Nuke users
([#2971](#2971))
([0d90cc9](0d90cc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
@sfc-gh-jcieslak
Copy link
Collaborator

sfc-gh-jcieslak commented Sep 5, 2024

Hey all 👋
Yesterday, we released a new provider version (v0.95.0) that adds this parameter. Please upgrade and let us know if now you can set OAUTH_ADD_PRIVILEGED_ROLES_TO_BLOCKED_LIST .

@bob-zarkoob
Copy link
Author

@sfc-gh-jcieslak I am trying to upgrade to 0.95.0 and getting this error:

│ Could not retrieve the list of available versions for provider snowflake-labs/snowflake: no available releases match the given constraints 0.94.1, 0.95.0

and when I open my TF files in the editor, I get unknown provider warning and all my code is highlighted

@sfc-gh-jcieslak
Copy link
Collaborator

Hmm, that's interesting; what OS/distro are you running the provider on?

@bob-zarkoob
Copy link
Author

Hmm, that's interesting; what OS/distro are you running the provider on?

I am on Windows 11, 23H2.

@sfc-gh-jcieslak
Copy link
Collaborator

There could be some kind of issue with the Terraform Registry syncing binaries from our repository. We re-synced the registry. It may take several minutes to fully re-sync, but after some time, you can try again and let us know if it works now or if the error still occurs.

@bob-zarkoob
Copy link
Author

I still cannot load the metadata for the provider, I get error for all resources because my IDE cannot validate the definition, so I have to run terraform to make sure I am using the properties correctly.

Also, I am getting this error without even making a change to that file:

on security/users.tf line 92, in resource "snowflake_user" "xxxxx":
  default_secondary_roles = "ALL"
An argument named "default_secondary_roles" is not expected here.

@sfc-gh-asawicki
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to mark issues with provider's incorrect behavior
Projects
None yet
Development

No branches or pull requests

3 participants