Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Resource monitor v1 readiness #3052

Merged
merged 8 commits into from
Sep 11, 2024
Merged

feat: Resource monitor v1 readiness #3052

merged 8 commits into from
Sep 11, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Sep 9, 2024 •
edited
Loading

Changes

Next pr

  • Adjust examples and update migration notes
  • Data source (impl, tests, examples, migration notes)

References

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Integration tests cancelled for f49e44e29095a967f98446c889465a0eb3ad963f

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Integration tests failure for 97c6cd9cb033c5b96287ab59552006c0c14ecee6

sfc-gh-asawicki
sfc-gh-asawicki requested changes Sep 9, 2024
View reviewed changes
pkg/acceptance/bettertestspoc/config/model/database_role_model_gen.go Outdated Show resolved Hide resolved
pkg/sdk/testint/resource_monitors_integration_test.go Show resolved Hide resolved
pkg/sdk/resource_monitors_test.go Show resolved Hide resolved
pkg/resources/resource_monitor.go Show resolved Hide resolved
pkg/resources/resource_monitor.go Outdated Show resolved Hide resolved
pkg/resources/resource_monitor.go Show resolved Hide resolved
sfc-gh-jmichalak
sfc-gh-jmichalak requested changes Sep 10, 2024
View reviewed changes
framework/provider/resource_monitor_resource.go Show resolved Hide resolved
pkg/resources/resource_monitor.go Show resolved Hide resolved
pkg/sdk/resource_monitors.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for da3503b235c5484f8276ec7ef339239dc7d6824c

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit ac493f4 into main Sep 11, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the resource-monitor-v1-readiness branch September 11, 2024 09:14
@github-actions GitHub Actions
Copy link

Integration tests cancelled for 07e8a2c41a0b440e413b0a9a0dd18fc6e8aabc8f

@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 10, 2024
Merged
@github-actions GitHub Actions
Copy link

Integration tests failure for 1e4b1c8f828bb74c391993734eda5577e9209ac7

sfc-gh-fbudzynski pushed a commit that referenced this pull request Sep 19, 2024
@sfc-gh-jcieslak @sfc-gh-fbudzynski
feat: Resource monitor v1 readiness (#3052)
42fd40a 
## Changes
- Add ValuePresent assert to our custom assertions
- Add ToConfigValues function for every model
- Update Resource Monitor SDK + unit and integration tests
- Update Resource Monitor Resource + acc tests
- Handle issues connected to the resource monitor (mostly timestamp
format difference causing infinite plan or only trigger updates causing
SQL compilation error):
  -  #1500 
  - #1624 
  - #1716 
  - #1754 
  - #1821 
  - #1832 
  - #1990

## Next pr
- Adjust examples and update migration notes
- Data source (impl, tests, examples, migration notes)

## References
* [CREATE RESOURCE
MONITOR](https://docs.snowflake.com/en/sql-reference/sql/create-resource-monitor)
sfc-gh-jmichalak pushed a commit that referenced this pull request Sep 19, 2024
@snowflake-release-please
chore(main): release 0.96.0 (#3042)
18f2ce4 
🤖 I have created a release *beep* *boop*
---


##
[0.96.0](v0.95.0...v0.96.0)
(2024-09-18)

Essential GA object readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)).

:exclamation: Migration guide: [v0.95.0 ->
v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960)

### 🎉 **What's new:**

* V1 redesign of resources and data sources
* Row access policy
([#3066](#3066))
([#3063](#3063))
* Resource monitor
([#3052](#3052))
([#3064](#3064))
* Masking policy
([#3078](#3078))
([#3083](#3083))
* SDK upgrades
* External volume
([#3033](#3033))
* Authentication policy
([#2937](#2937))
([#3068](#3068))
([#3061](#3061))


### 🔧 **Misc**

* Clean up old test object helpers
([#3049](#3049))
* Add example of granting role to multiple objects
([#3047](#3047))
* Update readme and objects rework state
([#3046](#3046))

### 🐛 **Bug fixes:**

* Fix model grants
([#3070](#3070))
* Fix database show by and resource logic
([#3055](#3055))
* Fix default secondary roles option import
([#3041](#3041))
* Fix sweepers for warehouse and database
([#3057](#3057))
* Fix views permadiff
([#3079](#3079))
* Update v0.95.0 migration guide
([#3062](#3062))

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak